vtexplain: handle sequence comments case-insensitively - #20776
Open
Taeknology wants to merge 1 commit into
Open
Conversation
Signed-off-by: Taeknology <20297177+Taeknology@users.noreply.github.com>
vitess-bot
Bot
added
NeedsWebsiteDocsUpdate
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes vtexplain sequence detection when DDL uses non-lowercase COMMENT.
Changes:
- Uses case-insensitive matching for the
COMMENToption. - Adds regression coverage for lowercase, uppercase, and mixed-case variants.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
go/vt/vtexplain/vtexplain_vttablet.go |
Matches the table-option keyword case-insensitively. |
go/vt/vtexplain/vtexplain_test.go |
Tests sequence-backed inserts across keyword casing variants. |
Taeknology
marked this pull request as ready for review
July 31, 2026 11:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
vtexplain now recognizes sequence tables when the DDL uses uppercase or mixed-case
COMMENT. The parser preserves table-option keyword casing, so the previous case-sensitive comparison omitted thevitess_sequencemetadata.The option keyword comparison now uses
strings.EqualFold, while thevitess_sequencesentinel remains exact. The regression test exercises lowercase, uppercase, and mixed-case forms through the user-visible vtexplain insert path.Related Issue(s)
Fixes #14941
Checklist
Deployment Notes
vtexplain now accepts case-insensitive SQL spelling of the
COMMENTtable option when identifyingvitess_sequencetables. No migration or runtime deployment steps are required.AI Disclosure
This PR was developed with assistance from an LLM. I made all key decisions, determined the technical direction, and personally reviewed and validated the final changes.